[XDP] Initial NPU3 support #9130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 12, 2025 17:19
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
added 2 commits
September 10, 2025 13:09
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Jain <[email protected]>
Signed-off-by: Jain <[email protected]>
This reverts commit 9b4dd94.
Signed-off-by: Jain <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| uint8_t burstLength; | ||
| uint8_t type; | ||
|
|
||
| TraceGMIO(uint32_t i, uint8_t col, uint8_t num, |
There was a problem hiding this comment.
warning: 6 adjacent parameters of 'TraceGMIO' of convertible types are easily swapped by mistake [bugprone-easily-swappable-parameters]
TraceGMIO(uint32_t i, uint8_t col, uint8_t num,
^Additional context
src/runtime_src/xdp/profile/database/static_info/aie_constructs.h:214: the first parameter in the range is 'i'
TraceGMIO(uint32_t i, uint8_t col, uint8_t num,
^src/runtime_src/xdp/profile/database/static_info/aie_constructs.h:215: the last parameter in the range is 't'
uint8_t stream, uint8_t len, uint8_t t = 0)
^src/runtime_src/xdp/profile/database/static_info/aie_constructs.h:214:
TraceGMIO(uint32_t i, uint8_t col, uint8_t num,
^src/runtime_src/xdp/profile/database/static_info/aie_constructs.h:214: 'uint32_t' and 'uint8_t' may be implicitly converted: 'uint32_t' (as 'unsigned int') -> 'uint8_t' (as 'unsigned char'), 'uint8_t' (as 'unsigned char') -> 'uint32_t' (as 'unsigned int')
TraceGMIO(uint32_t i, uint8_t col, uint8_t num,
^| configWriter = new AieTraceConfigWriter(configFile.c_str(), deviceID); | ||
| writers.push_back(configWriter); | ||
| (db->getStaticInfo()) | ||
| .addOpenedFile(configWriter->getcurrentFileName(), |
There was a problem hiding this comment.
warning: no member named 'addOpenedFile' in 'xdp::VPStaticDatabase' [clang-diagnostic-error]
.addOpenedFile(configWriter->getcurrentFileName(),
^Signed-off-by: Paul Schumacher <[email protected]>
parthash0804
force-pushed
the
next_gen_aie_devel
branch
from
fd0a41a to
d475a92
Compare
parthash0804
requested review from
AShivangi,
chvamshi-xilinx,
rozumx and
stsoe
as code owners
parthash0804
force-pushed
the
next_gen_aie_devel
branch
from
d475a92 to
fd0a41a
Compare
Signed-off-by: Jyotheeswar Ganne <[email protected]>
On behalf of Jain <[email protected]>, I, Paul Schumacher <[email protected]>, hereby add my Signed-off-by to this commit: 304f91d Signed-off-by: Paul Schumacher <[email protected]>
Signed-off-by: Paul Schumacher <[email protected]>
…aie_devel Signed-off-by: Jain <[email protected]>
… in aie_profile npu3 Signed-off-by: Jyotheeswar Ganne <[email protected]>
Signed-off-by: Jain <[email protected]>
…t_gen_aie_devel
…t_gen_aie_devel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
XDP needed support for NPU3
How problem was solved, alternative solutions (if any) and why they were rejected
Added extensive support for NPU3
Risks (if any) associated the changes in the commit
Support affects many files and build environments
What has been tested and how, request additional testing if necessary
Simulation of NPU3
Documentation impact (if any)
New events, metric sets, etc.